Fix smithy sets #673
Merged
Fix smithy sets #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
lucix-aws
approved these changes
Jul 12, 2022
| @@ -546,7 +546,7 @@ class DeserializeStructGeneratorTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun `it deserializes a structure containing a set of primitive values`() { | |||
| fun `it deserializes a structure containing a list of unique primitive values`() { | |||
There was a problem hiding this comment.
I think we landed on a convention for test names in some random PR discussion and then we never codified it. 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Missed during the recent Smithy 1.22 upgrade was that sets should be fully replaced with lists even in codegen (i.e., not just models). Thus, no longer generating
Set<T>for members and ignoring@uniqueItemstraits.This is a breaking change which will mandate a minor version bump.
Companion PR: aws-sdk-kotlin#652
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.