fix: stop serializing default values for @clientOptional members #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
aajtodd
approved these changes
Aug 14, 2023
lauzadis
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes awslabs/aws-sdk-kotlin#1016
Description of changes
The SDK incorrectly serializes structure members' default values in requests regardless of the
@clientOptionaltrait. As recently clarified in Smithy reference docs,@clientOptionalsupersedes@defaultand should cause serializers to skip recognizing/sending a default value.This affected EC2's
DescribeVpcsRequest.MaxResultsand potentially many other structure members.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.