Fix CI for 1.44.0 bump #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test depended on the ordering of validation events, which 1.44.0 changes.
syall
approved these changes
Feb 7, 2024
hpmellema
reviewed
Feb 7, 2024
| String expectedMessage = "Proto index 1 is used muliple times in members name," + | ||
| "age of shape (structure: `some.test#MyStruct`)."; | ||
| Optional<ValidationEvent> matchingEvent = validationEvents.stream() | ||
| .filter(ev ->ev.getMessage().equals(expectedMessage)).findFirst(); |
There was a problem hiding this comment.
nit: I think you could a hamcrest matcher (or orElseThrow) to make this a little cleaner
assertThat(validationEvents, hasItem(hasProperty("message", equals(expectedMessage)))
or
.orElseThrow(() -> new AssertionError(...))
There was a problem hiding this comment.
I would if we used hamcrest in the language server. Will be adding it in the future though.
hpmellema
approved these changes
Feb 7, 2024
sugmanue
reviewed
Feb 7, 2024
| validationEvents.get(0).getMessage() | ||
| ); | ||
|
|
||
| String expectedMessage = "Proto index 1 is used muliple times in members name," + |
There was a problem hiding this comment.
Nit, there is a typo on "muliple" and a missing white space after the comma.
There was a problem hiding this comment.
Yea, that's just the message the validator produces, which lives in a jar in test resources. I don't remember where exactly it came from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test depended on the ordering of validation events, which 1.44.0 changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.