Re-enable service smoke tests #3863
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 5, 2024
## Motivation and Context `SmokeTestsDecorator` needs more test cases for it to be used reliably. Till #3863 has been resolved, we will stop code generating service smoke tests. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Rust SDK does not execute the service smoke tests in the release pipeline at this time (neither do the majority of the other SDKs). To avoid potential build failures from tests that are not executed in the pipeline, #3864 has stopped generating smoke tests.
However, the service teams can still add their smoke tests in their models, which may uncover potential implementation bugs in currently commented-out
SmokeTestsDecorator, causing build failures in the future when we enable smoke tests. Our approach is that we will handle those potential implementation bugs in one go when we do enable them (adding necessary unit tests at that time), rather than periodically checking the implementation ofSmokeTestsDecoratorusing some sort of a CI job.The text was updated successfully, but these errors were encountered: