Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nightly used in CI #3073

Merged
merged 20 commits into from
Dec 14, 2023
Merged

Upgrade nightly used in CI #3073

merged 20 commits into from
Dec 14, 2023

Conversation

jdisanti
Copy link
Collaborator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti
Copy link
Collaborator Author

jdisanti commented Dec 7, 2023

Looks like the CI failure is caused by new rustdoc warnings, which, paired with -D warnings, is causing cargo-check-external-types to fail.

@smithy-lang smithy-lang deleted a comment from github-actions bot Dec 7, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Dec 7, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Dec 7, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Dec 7, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

Copy link

github-actions bot commented Dec 7, 2023

Copy link

github-actions bot commented Dec 7, 2023

Copy link

github-actions bot commented Dec 7, 2023

@jdisanti jdisanti marked this pull request as ready for review December 7, 2023 22:06
@jdisanti jdisanti requested review from a team as code owners December 7, 2023 22:06
Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing a lot of doc links!

Copy link

github-actions bot commented Dec 8, 2023

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@jdisanti jdisanti changed the title Upgrade nightly used in CI Upgrade nightly and Kotlin Dec 14, 2023
@jdisanti jdisanti force-pushed the jdisanti-upgrade-nightly branch from e5227f4 to 9aa0b53 Compare December 14, 2023 18:46
@jdisanti jdisanti changed the title Upgrade nightly and Kotlin Upgrade nightly used in CI Dec 14, 2023
@jdisanti jdisanti added the ready-to-merge This PR is ready to merge into `main` label Dec 14, 2023
@jdisanti jdisanti enabled auto-merge December 14, 2023 18:48
Copy link

@jdisanti jdisanti disabled auto-merge December 14, 2023 19:30
@jdisanti jdisanti merged commit aa1f556 into main Dec 14, 2023
41 checks passed
@jdisanti jdisanti deleted the jdisanti-upgrade-nightly branch December 14, 2023 19:30
@jdisanti
Copy link
Collaborator Author

It looks like #3298 was unintentionally merged into this PR before it was merged to main. So this PR included the MSRV upgrade as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is ready to merge into `main`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants