New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix canary target to wasm32-wasip1 #3966

Merged

aajtodd merged 6 commits into main from fix-canary-wasm

Jan 14, 2025

Contributor

aajtodd commented Jan 13, 2025

Motivation and Context

P180666804

Description

Release 1.84 removed support for the wasm32-wasi target:

Support for the target named wasm32-wasi has been removed as the target is now named wasm32-wasip1. This completes the transition plan for this target following the introduction of wasm32-wasip1 in Rust 1.78. Compiler warnings on use of wasm32-wasi introduced in Rust 1.81 are now gone as well as the target is removed.

Updates wasm32-wasi target to wasm32-wasip1 which should fix the canary on stable (example failed run).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


          fix canary target to wasm32-wasip1

506ad93

aajtodd requested review from a team as code owners

January 13, 2025 16:12

github-actions bot commented Jan 13, 2025

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          fix ci

61dc002

github-actions bot commented Jan 13, 2025

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          add debug output to canary

018fc2a

github-actions bot commented Jan 13, 2025

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          update wasm tooling to latest

a2ac736

github-actions bot commented Jan 14, 2025

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

aajtodd added 2 commits

January 14, 2025 11:02


          Merge remote-tracking branch 'origin/main' into fix-canary-wasm

61f29b1


          update lockfiles

be1c591

github-actions bot commented Jan 14, 2025

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

landonxjames approved these changes

View reviewed changes

Contributor

landonxjames left a comment

LGTM

aajtodd added this pull request to the merge queue

aajtodd mentioned this pull request

Run cargo update on the runtime lockfiles and the SDK lockfile #3963

Closed

ysaito1001 approved these changes

View reviewed changes

Merged via the queue into main with commit cadce6c

43 of 44 checks passed

aajtodd deleted the fix-canary-wasm branch

January 14, 2025 20:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet