-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example code to use write_all_buf method #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you change the Tokio dependency in smithy-http to 1.6? That will ensure that this builds for everyone
Absolutely. Let me do that. |
Test:
All successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution!
Looks like the build failed for a cargofmt check—can you run |
Okay. Let me update it. I thought the test would have caught the fmt failure :P. But I guess I should've run cargo fmt after I made the change. :) |
yeah I think that's an oversight that I'll fix. In the future, installing |
Just updated. |
Hi @rcoh Looks like the workflow needs to be approved to run |
Small PR, related to #349
*This PR updated the example code to use the lastest supported method
write_all_buf
fromAsyncWriteExt
trait (tokio-rs/tokio#3737) to make example less verbose *By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Test:
./gradlew :aws:sdk:test
passed locally.BUILD SUCCESSFUL in 8m 41s
Please let me know if you have any feedbacks. Thanks!