Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log requestId, extendedRequestId, cfId in $metadata #252

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Dec 21, 2020

Issue #, if available:
Refs: aws/aws-sdk-js-v3#1521
Refs: aws/aws-sdk-js-v3#1522
Resolves: aws/aws-sdk-js-v3#1490

Description of changes:
log requestId, extendedRequestId, cfId in $metadata

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

@trivikr trivikr merged commit 6e2af31 into smithy-lang:master Dec 23, 2020
@trivikr trivikr deleted the update-metadata branch December 23, 2020 17:57
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove $metadata from API response
2 participants