change runtime config from constant to provider functions #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
runtime-config-function
branch
from
89a3417
to
0d30136
Compare
trivikr
approved these changes
Jul 21, 2021
| writer.onSection("customizations", original -> { | ||
| writer.indent(); | ||
| writer.indent().onSection("customizations", original -> { | ||
| // writer.indent(); |
There was a problem hiding this comment.
nit: remove line
Suggested change
| // writer.indent(); |
AllanZhengYP
force-pushed
the
runtime-config-function
branch
from
0d30136
to
7f71281
Compare
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
…g#381) * make runtime config functional * assign configs not defined in runtime config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to aws/aws-sdk-js-v3#2574
Description of changes:
See: aws/aws-sdk-js-v3#2574
This change makes runtime default configs as a function instead of constant. As a result, different client instance won't share the same runtime config (e.g. HTTP handlers). This change also uses inline nullish coalescing in replace of fully loaded default configuration. This change makes sure the SDK won't load default value/provider at all when corresponding custom config is supplied.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.