Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos for "ignore" #1652

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Fix typos for "ignore" #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c53f97f
Fix typos on "Ignored" in smithy-aws-protocol-tests
Mar 3, 2023
2419f31
Fix typos on "IgnoreMe" in smithy-model
Mar 3, 2023
e6dbb36
Fix typos for NodeMapper.WhenMissing.IGNORE
Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...udformation/src/main/java/software/amazon/smithy/aws/cloudformation/schema/CfnConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ public void setUnionStrategy(UnionStrategy unionStrategy) {
public static CfnConfig fromNode(Node settings) {
NodeMapper mapper = new NodeMapper();

mapper.setWhenMissingSetter(NodeMapper.WhenMissing.INGORE);
mapper.setWhenMissingSetter(NodeMapper.WhenMissing.IGNORE);

ObjectNode node = settings.expectObjectNode();
CfnConfig config = new CfnConfig();
Expand Down
2 changes: 1 addition & 1 deletion smithy-aws-protocol-tests/model/awsQuery/xml-structs.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ structure XmlNamespacesOutput {
nested: XmlNamespaceNested
}

// Ingored since it's not at the top-level
// Ignored since it's not at the top-level
@xmlNamespace(uri: "http://boo.com")
structure XmlNamespaceNested {
@xmlNamespace(uri: "http://baz.com", prefix: "baz")
Expand Down
2 changes: 1 addition & 1 deletion smithy-aws-protocol-tests/model/ec2Query/xml-structs.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ structure XmlNamespacesOutput {
nested: XmlNamespaceNested
}

// Ingored since it's not at the top-level
// Ignored since it's not at the top-level
@xmlNamespace(uri: "http://foo.com")
structure XmlNamespaceNested {
@xmlNamespace(uri: "http://baz.com", prefix: "baz")
Expand Down
2 changes: 1 addition & 1 deletion smithy-aws-protocol-tests/model/restXml/document-structs.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,7 @@ structure XmlNamespacesInputOutput {
nested: XmlNamespaceNested
}

// Ingored since it's not at the top-level
// Ignored since it's not at the top-level
@xmlNamespace(uri: "http://foo.com")
structure XmlNamespaceNested {
@xmlNamespace(uri: "http://baz.com", prefix: "baz")
Expand Down
2 changes: 1 addition & 1 deletion smithy-jsonschema/src/main/java/software/amazon/smithy/jsonschema/JsonSchemaConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public String toString() {
private boolean useIntegerType;

public JsonSchemaConfig() {
nodeMapper.setWhenMissingSetter(NodeMapper.WhenMissing.INGORE);
nodeMapper.setWhenMissingSetter(NodeMapper.WhenMissing.IGNORE);
}

public boolean getAlphanumericOnlyRefs() {
Expand Down
2 changes: 1 addition & 1 deletion smithy-model/src/main/java/software/amazon/smithy/model/node/NodeMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public void handle(Type into, String pointer, String property, Node value) {
/**
* Ignores unknown properties.
*/
INGORE {
IGNORE {
public void handle(Type into, String pointer, String property, Node value) {
}
};
Expand Down
2 changes: 1 addition & 1 deletion ...src/test/resources/software/amazon/smithy/model/errorfiles/loader/suppression-test.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ metadata suppressions = [

namespace smithy.example

@suppress(["IngoreMe"])
@suppress(["IgnoreMe"])
service MyService {
version: "XYZ",
operations: [GetFoo],
Expand Down
2 changes: 1 addition & 1 deletion smithy-openapi/src/main/java/software/amazon/smithy/openapi/OpenApiConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ public static OpenApiConfig fromNode(Node input) {
// warning on something intentional is just noise. It sucks
// that this can't tell us when keys are misspelled, but it
// does allow for a flat key-space for all extensions.
mapper.setWhenMissingSetter(NodeMapper.WhenMissing.INGORE);
mapper.setWhenMissingSetter(NodeMapper.WhenMissing.IGNORE);

// Fix and remap deprecated keys to newly supported keys.
ObjectNode node = fixDeprecatedKeys(input.expectObjectNode());
Expand Down
2 changes: 1 addition & 1 deletion smithy-openapi/src/main/java/software/amazon/smithy/openapi/model/ExampleObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public static ExampleObject fromNode(Node exampleObject) {
return null;
}
NodeMapper mapper = new NodeMapper();
mapper.setWhenMissingSetter(NodeMapper.WhenMissing.INGORE);
mapper.setWhenMissingSetter(NodeMapper.WhenMissing.IGNORE);
ObjectNode node = exampleObject.expectObjectNode();
ExampleObject.Builder result = new ExampleObject.Builder();
mapper.deserializeInto(node, result);
Expand Down