DLC 2 Support for calculator #591
Conversation
ShivaD173
commented
Dec 17, 2023
ShivaD173
commented
- Still Waiting for Dex to pass tests, but keeping PR ready
- Added all new pokemon, moves, and abilities
- Added Mechanics for new moves and abilites
- Added support for Terestal Tera Type, right now always assumes boost. Let me know if better way to do it.
calc/src/mechanics/util.ts
Outdated
| field.weather = undefined; | ||
| } | ||
| if (pokemon.hasAbility('Teraform Zero')) { |
There was a problem hiding this comment.
If you're implementing Teraform Zero specific mechanics it should be in its own function.
Plus, since this only happens once a battle it should be checking the abilityActive property or whatever its called.
calc/src/mechanics/gen789.ts
Outdated
| @@ -338,6 +338,14 @@ export function calculateSMSSSV( | |||
| desc.weather = field.weather; | |||
| } | |||
|
|
|||
| if (defender.hasAbility('Tera Shell')) { | |||
There was a problem hiding this comment.
This only happens if its also at full HP (check multiscale implementation).
calc/src/mechanics/gen789.ts
Outdated
| typeEffectiveness = 0.5; | ||
| } | ||
|
|
||
| if (attacker.teraType === 'Stellar' && defender.teraType !== undefined) { |
There was a problem hiding this comment.
This should be before the Tera Shell check.
There was a problem hiding this comment.
This also looks like it makes all attacks from Stellar tera'd mons to be super effective, when it should just be Tera Blast and Tera Starstorm
@pkmn/dex has been update with DLC2 as of a few hours ago. |
calc/src/data/types.ts
Outdated
| @@ -406,7 +406,51 @@ const SM = XY; | |||
|
|
|||
| const SS = SM; | |||
|
|
|||
| const SV = SS; | |||
| // const SV = SS; | |||
calc/src/data/types.ts
Outdated
| Psychic: {Stellar: 1}, | ||
| Ghost: {Stellar: 1}, | ||
| Dragon: {Stellar: 1}, | ||
| Dark: {Steel: 1, Stellar: 1}, |
There was a problem hiding this comment.
Is there a reason to specify Steel: 1?
|
Doesn't your implementation mean that Stellar Pokemon are neutral to everything defensively? |
|
Fixed these bugs listed, thanks for the review. |
I'll work on that right now and when I'm done I'll merge your PR and push my commit. Hopefully we can finish this today :). |
|
Great work, thank you! |
