Catch panics in the default platform and add comment to Platform
#1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #519
cc @lexnv @skunert (you are the two embedders of smoldot that I know of)
Smoldot now supports restarting some services if they crash (of course this is done properly, so JSON-RPC functions send back errors and things like that). Consequently, if a task panics, you are encouraged to not just propagate panics and let the thread crash, but instead silently drop the task and continue running.
I've considered instead adding
.catch_unwindinternally within smoldot's code everywhere relevant, but I think that it's better to make the embedder aware of this.