fix(tcpdump): partial checksum #1015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Nov 29, 2024
src/wire/ip.rs
Outdated
| let partially_valid = udp_packet | ||
| .verify_partial_checksum(&repr.src_addr(), &repr.dst_addr()); | ||
|
|
||
| format_checksum(f, valid || partially_valid) |
There was a problem hiding this comment.
I'd prefer different formatting for valid vs partially valid checksum, since this is a diagnostic interface.
There was a problem hiding this comment.
I modified the message when the partial checksum is correct.
thvdveld
force-pushed
the
partial-checksum
branch
from
8ec1376 to
a3abf9c
Compare
In some cases, the checksum calculation is offloaded to hardware and only the partial checksum is calculated (only the pseudo-header). The tcpdump example was not taking this into account and was flagging some packets with incorrect checksums.
thvdveld
force-pushed
the
partial-checksum
branch
from
a3abf9c to
dff1c20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 80.75% 80.77% +0.01%
==========================================
Files 81 81
Lines 28340 28415 +75
==========================================
+ Hits 22887 22953 +66
- Misses 5453 5462 +9 ☔ View full report in Codecov by Sentry. |
whitequark
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the checksum calculation is offloaded to hardware and only the partial checksum is calculated (only the pseudo-header). The tcpdump example was not taking this into account and was flagging some packets with incorrect checksums.