fix: Fix linter deprecation warnings

.golangci.yml

@@ -256,18 +256,15 @@ output:
 
 linters:
   enable:
-    - deadcode
+    - unused
     - gocyclo
-    - golint
-    - varcheck
-    - structcheck
-    - maligned
+    - revive
     - errcheck
     - ineffassign
-    - interfacer
     - unconvert
     - goconst
     - gosec
+    - govet
     - megacheck
   #disable:
   #  - maligned
@@ -310,9 +307,9 @@ issues:
     #  text: "SA9003:"
 
     # Exclude lll issues for long lines with go:generate
-    - linters:
-        - errcheck
-      text: "Error return value of `d.Set` is not checked"
+    # - linters:
+    #     - errcheck
+    #   text: "Error return value of `d.Set` is not checked"
     #  source: "^//go:generate "
 
   # Independently from option `exclude` we use default exclude patterns,

netbox/dcim/data_netbox_dcim_platform.go

@@ -58,7 +58,9 @@ func dataNetboxDcimPlatformRead(ctx context.Context, d *schema.ResourceData, m i
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/dcim/data_netbox_dcim_site.go

@@ -58,7 +58,9 @@ func dataNetboxDcimSiteRead(ctx context.Context, d *schema.ResourceData, m inter
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/ipam/data_netbox_ipam_aggregate.go

@@ -62,7 +62,9 @@ func dataNetboxIpamAggregateRead(ctx context.Context, d *schema.ResourceData,
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/ipam/data_netbox_ipam_ip_addresses.go

@@ -56,7 +56,9 @@ func dataNetboxIpamIPAddressesRead(ctx context.Context, d *schema.ResourceData,
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/ipam/data_netbox_ipam_role.go

@@ -58,7 +58,9 @@ func dataNetboxIpamRoleRead(ctx context.Context, d *schema.ResourceData, m inter
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/ipam/data_netbox_ipam_service.go

@@ -93,7 +93,9 @@ func dataNetboxIpamServiceRead(ctx context.Context, d *schema.ResourceData,
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/ipam/data_netbox_ipam_vlan.go

@@ -64,7 +64,9 @@ func dataNetboxIpamVlanRead(ctx context.Context, d *schema.ResourceData, m inter
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/ipam/data_netbox_ipam_vlan_group.go

@@ -58,7 +58,9 @@ func dataNetboxIpamVlanGroupRead(ctx context.Context, d *schema.ResourceData, m
 
 	r := list.Payload.Results[0]
 	d.SetId(strconv.FormatInt(r.ID, 10))
-	d.Set("content_type", util.ConvertURIContentType(r.URL))
+	if err = d.Set("content_type", util.ConvertURIContentType(r.URL)); err != nil {
+		return diag.FromErr(err)
+	}
 
 	return nil
 }

netbox/ipam/resource_netbox_ipam_ip_addresses.go

@@ -147,15 +147,19 @@ func resourceNetboxIpamIPAddressesCreate(ctx context.Context, d *schema.Resource
 		}
 		address = *ip.Address
 		addressid = &ip.ID
-		d.Set("address", address)
+		if err := d.Set("address", address); err != nil {
+			return diag.FromErr(err)
+		}
 	} else if rangeid, ok := d.GetOk("ip_range"); ok {
 		ip, err := getNewAvailableIPForIPRange(client, int64(rangeid.(int)))
 		if err != nil {
 			return diag.FromErr(err)
 		}
 		address = *ip.Address
 		addressid = &ip.ID
-		d.Set("address", address)
+		if err := d.Set("address", address); err != nil {
+			return diag.FromErr(err)
+		}
 	} else {
 		return diag.Errorf("exactly one of (address, ip_range, prefix) must be specified")
 	}