fix: Status field missing from cluster resource

fixes: #190
smutel · Mar 14, 2023 · 74f5147 · 74f5147
1 parent a93a3c9
commit 74f5147
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/netbox/internal/util/nested.go b/netbox/internal/util/nested.go
@@ -4,6 +4,14 @@ import (
 	"github.com/smutel/go-netbox/v3/netbox/models"
 )
 
+func GetClusterStatusValue(nested *models.ClusterStatus) *string {
+	if nested == nil {
+		return nil
+	}
+
+	return nested.Value
+}
+
 func GetNestedIPAddressAddress(nested *models.NestedIPAddress) *string {
 	if nested == nil {
 		return nil

diff --git a/netbox/virtualization/resource_netbox_virtualization_cluster.go b/netbox/virtualization/resource_netbox_virtualization_cluster.go
@@ -72,6 +72,14 @@ func ResourceNetboxVirtualizationCluster() *schema.Resource {
 				Optional:    true,
 				Description: "The site of this cluster.",
 			},
+			"status": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Default:  "active",
+				ValidateFunc: validation.StringInSlice([]string{"offline", "active",
+					"planned", "staging", "decommissioning"}, false),
+				Description: "The status among offline, active, planned, staging or decommissioning (active by default).",
+			},
 			"tag": &tag.TagSchema,
 			"tenant_id": {
 				Type:        schema.TypeInt,
@@ -126,6 +134,7 @@ func resourceNetboxVirtualizationClusterCreate(ctx context.Context, d *schema.Re
 		Name:         &name,
 		Tags:         tag.ConvertTagsToNestedTags(tags),
 		Type:         &typeID,
+		Status:       d.Get("status").(string),
 	}
 
 	if groupID != 0 {
@@ -199,6 +208,9 @@ func resourceNetboxVirtualizationClusterRead(ctx context.Context, d *schema.Reso
 	if err = d.Set("site_id", util.GetNestedSiteID(resource.Site)); err != nil {
 		return diag.FromErr(err)
 	}
+	if err = d.Set("status", util.GetClusterStatusValue(resource.Status)); err != nil {
+		return diag.FromErr(err)
+	}
 	if err = d.Set("tag", tag.ConvertNestedTagsToTags(resource.Tags)); err != nil {
 		return diag.FromErr(err)
 	}
@@ -247,6 +259,9 @@ func resourceNetboxVirtualizationClusterUpdate(ctx context.Context, d *schema.Re
 		name := d.Get("name").(string)
 		params.Name = &name
 	}
+	if d.HasChange("status") {
+		params.Status = d.Get("status").(string)
+	}
 	if d.HasChange("site_id") {
 		siteID := int64(d.Get("site_id").(int))
 		params.Site = &siteID

diff --git a/netbox/virtualization/resource_netbox_virtualization_cluster_test.go b/netbox/virtualization/resource_netbox_virtualization_cluster_test.go
@@ -126,6 +126,7 @@ func testAccCheckNetboxVirtualizationClusterConfig(nameSuffix string, resourceFu
 		group_id  = netbox_virtualization_cluster_group.test.id
 		site_id   = netbox_dcim_site.test.id
 		tenant_id = netbox_tenancy_tenant.test.id
+		status    = "decommissioning"
 
 		comments = <<-EOT
 		Test cluster