fix: Fix choices field for select and multiselect custom field

smutel · May 23, 2023 · e7c882c · e7c882c
1 parent abd3269
commit e7c882c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/netbox/extras/resource_netbox_extras_custom_field.go b/netbox/extras/resource_netbox_extras_custom_field.go
@@ -170,6 +170,7 @@ func ResourceNetboxExtrasCustomField() *schema.Resource {
 
 var customFieldRequiredFields = []string{
 	"created",
+	"choices",
 	"last_updated",
 	"name",
 	"slug",

diff --git a/netbox/extras/resource_netbox_extras_custom_field_multiselect_test.go b/netbox/extras/resource_netbox_extras_custom_field_multiselect_test.go
@@ -99,12 +99,12 @@ func testAccCheckNetboxExtrasCustomFieldMultiSelectConfig(nameSuffix string, res
 		]
 
 		type          = "multiselect"
-		{{ if eq .resourcefull "true" }}
-		description   = "Test custom field"
 		choices = [
 			"test",
 			"test2"
 		]
+		{{ if eq .resourcefull "true" }}
+		description   = "Test custom field"
 		label         = "Test Label for CF"
 		group_name    = "testgroup"
 		ui_visibility = "hidden"

diff --git a/netbox/extras/resource_netbox_extras_custom_field_select_test.go b/netbox/extras/resource_netbox_extras_custom_field_select_test.go
@@ -99,12 +99,12 @@ func testAccCheckNetboxExtrasCustomFieldSelectConfig(nameSuffix string, resource
 		]
 
 		type          = "select"
-		{{ if eq .resourcefull "true" }}
-		description   = "Test custom field"
 		choices = [
 			"test",
 			"test2"
 		]
+		{{ if eq .resourcefull "true" }}
+		description   = "Test custom field"
 		label         = "Test Label for CF"
 		group_name    = "testgroup"
 		ui_visibility = "hidden"