Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow a configurable basepath #48

Merged
merged 1 commit into from
Mar 12, 2021
Merged

feat: Allow a configurable basepath #48

merged 1 commit into from
Mar 12, 2021

Conversation

jacobstr
Copy link
Contributor

@jacobstr jacobstr commented Mar 10, 2021 •
edited by smutel
Loading

Fixes: #49

  • Pretty much as it says. Note: I haven't successfully tested this due to (what I suspect) version differences.
  • Allows for netbox running behind some url prefix. Should be backwards compatible.

Note: still have some yaks to shave here to confirm it's working, my install is currently < 2.8, but this was an obvious first thing we would need here.

@auto-assign auto-assign bot requested a review from smutel March 10, 2021 23:57
@smutel
Copy link
Owner

smutel commented Mar 11, 2021

Could you please:

  • Open an issue (bug report / new feature) related to this PR
  • Rebase your branch and rename the commit to follow conventional commits rules (should start by feat: [A-Z] or fix: [A-Z] or enh: [A-Z])

@jacobstr jacobstr force-pushed the jacobstr/configurable-basepath branch from 3f69b73 to ba8d739 Compare March 11, 2021 16:41
@smutel smutel changed the title allow a configurable basepath feat: Allow a configurable basepath Mar 11, 2021
@auto-add-label auto-add-label bot added the enhancement New feature or request label Mar 11, 2021
@smutel
Copy link
Owner

smutel commented Mar 11, 2021 •
edited
Loading

Replace allow by  Allow in your commit message and it will be perfect for merging.

@jacobstr
Copy link
Contributor Author

Ack. done.

@jacobstr jacobstr force-pushed the jacobstr/configurable-basepath branch from ba8d739 to 7392901 Compare March 11, 2021 23:13
smutel
smutel approved these changes Mar 12, 2021
View reviewed changes
Copy link
Owner

@smutel smutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@smutel smutel merged commit 39ac08b into smutel:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smutel smutel smutel approved these changes

Assignees

@smutel smutel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configurable API basePath.
2 participants
@jacobstr @smutel