Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an option to initialize the client with the private key #63

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

BonySmoke
Copy link

In the NetBox version prior to 3.0, to read encoded data from secrets, we would need to include the session key to a request.
The purpose of the PR is to add a possibility to initialize the client with the private key.

@auto-add-label auto-add-label bot added the enhancement New feature or request label Sep 14, 2021
@auto-assign auto-assign bot requested a review from smutel September 14, 2021 09:35
smutel
smutel previously approved these changes Sep 15, 2021
Copy link
Owner

@smutel smutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smutel
Copy link
Owner

smutel commented Sep 15, 2021

Could you please fixup all your commits with only one "feat: Add an option to initialize the client with the private key" ?
This will be use to generate the changelog.

@BonySmoke
Copy link
Author

BonySmoke commented Sep 15, 2021

I would like to clarify something:
Do I understand correctly that I need to squash these commits into one and push it with the message you mentioned?
So I would do something like this

git rebase -i HEAD~6 feat/add-private-key
change all commits from pick to squash
change commit message to "feat: Add an option to initialize the client with the private key"
git push origin feat/add-private-key --force

Or there is something else I need to do?

@BonySmoke
Copy link
Author

So, I actually needed to leave the first one as pick and change all the others to squash:)
Is it good now?

@smutel smutel merged commit 43e4185 into smutel:master Sep 15, 2021
@BonySmoke BonySmoke deleted the feat/add-private-key branch September 19, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants