fix: stable column ordering in count-matrix.py #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaehnemann
approved these changes
Feb 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #32.
Some analyses fail because the
count-matrix.pyscript inconsistently sorts output columns, especially when there are lots of units in theunits.tsvfile that span multiple sequencing lanes.The default behavior of the
pandas.matrix.groupbyfunction is to sort the grouping keys, but the sorting is not stable and causes the workflow to fail sometimes in thedeseq2_initrule of the analysis if the sorting happened to change the column ordering.Originally from PR #49. Please close that PR without merging @dlaehnemann