Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider changing default segmentNameCharset to 'a-zA-Z0-9_' #33

Open
snd opened this issue Nov 17, 2016 · 2 comments
Open

consider changing default segmentNameCharset to 'a-zA-Z0-9_' #33

snd opened this issue Nov 17, 2016 · 2 comments

Comments

@snd
Copy link
Owner

snd commented Nov 17, 2016

the current default is unexpected to some.

it's likely that this change will meet more expectations than the current default.

breaking change

see #32

@plandem
Copy link

plandem commented Feb 4, 2017

same case :(

p.s.: also it's good idea to export definition of UrlPatternOptions

@snd
Copy link
Owner Author

snd commented Apr 29, 2019

the next release will be based on typescript and since it will contain breaking changes it will contain this change as well.

i've converted url-pattern from coffeescript to typescript over on this branch: https://github.com/snd/url-pattern/tree/coffeescript-to-typescript. tests are passing. just need to adapt the rest of the repo (build, CI, docs) to the new language.

snd added a commit that referenced this issue Apr 30, 2019
snd added a commit that referenced this issue Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants