Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protected constructor for extension #15

Closed
B0SS opened this issue Jun 13, 2020 · 2 comments
Closed

Protected constructor for extension #15

B0SS opened this issue Jun 13, 2020 · 2 comments

Comments

@B0SS
Copy link

B0SS commented Jun 13, 2020

Hi,

Could you consider to switch the constructor from private to protected in order to extend the Guid class to override some methods (in my case the toJSON method).

Thanks
avmaisak added a commit to avmaisak/guid-typescript that referenced this issue Jun 16, 2020
@avmaisak
fixed
748bfc2 
 snico-dev#15
 snico-dev#14
avmaisak added a commit to avmaisak/guid-typescript that referenced this issue Jun 16, 2020
@avmaisak
fixed
9f30a2a 
 snico-dev#15
 snico-dev#14
avmaisak added a commit to avmaisak/guid-typescript that referenced this issue Jun 16, 2020
@avmaisak
fixed
01e95af 
 snico-dev#15
 snico-dev#14
@avmaisak
Copy link

@B0SS fixed. See
https://github.com/avmaisak/guid-typescript

@B0SS
Copy link
Author

B0SS commented Jun 16, 2020

Thanks a lot !

@B0SS B0SS closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avmaisak @B0SS