Fixes GUID/UUID generation to adhere to RFC 4122 UUID v4 specification #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N doesn't return a JSON string.
Rework validator to be easier to maintain.
…mply with RFC 4122 v4 GUID/UUID
Add tests for v4 version Add tests for v4 variant
|
Sorry, guy! I haven't been maintaining this repo for the past few years due to personal reasons. I'll review the requests and accept them soon. Thanks! |
|
@snico-dev if you are unwilling/unable to maintain this package, please mark it as deprecated and push a final release to NPM encouraging the use of a well-maintained library, such as |
|
@snico-dev is there anything I can do to help this PR get merged? |
|
bump |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that was causing nearly 98% of GUID/UUID values generated to be invalid. This may have caused issues with some parsers when the Version and Variant fields were not in expected value ranges (RFC expects version to be 1-5 and variant to be 8, 9, a, b).
See RFC 4122