Merge pull request #15794 from snipe/check_for_file_on_asset_acceptance

Check that the file exists before trying to download stored EULA
snipe · Nov 11, 2024 · 6bec573 · 6bec573
2 parents b6ad69f + 1fc5bb5
commit 6bec573
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/app/Http/Controllers/ActionlogController.php b/app/Http/Controllers/ActionlogController.php
@@ -37,10 +37,18 @@ public function displaySig($filename) : RedirectResponse | Response | bool
         }
     }
 
-    public function getStoredEula($filename) : Response | BinaryFileResponse
+    public function getStoredEula($filename) : Response | BinaryFileResponse | RedirectResponse
     {
         $this->authorize('view', \App\Models\Asset::class);
         $file = config('app.private_uploads').'/eula-pdfs/'.$filename;
-        return response()->download($file);
+
+        if (Storage::exists($file)) {
+            return response()->download($file);
+        }
+
+        return redirect()->back()->with('error',  trans('general.file_does_not_exist'));
+
+
+
     }
 }