Deleting a license updates a random seat #13341
Comments
|
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
Loemnk
pushed a commit
to Loemnk/snipe-it
that referenced
this issue
Jul 20, 2023
Before this, we checked for the `id` collumn in the `license_seats` table, insteasd of using `license_id` for this. This way, we ensure that we only alter seats belonging to the correct license.
7 tasks
snipe
added a commit
that referenced
this issue
Jul 20, 2023
Fixes #13341: Clean up correct seats on license delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Debug mode
Describe the bug
When you have two licenses:
When you now delete License B, and License A has a seat with the id of License A, then the fields
assigned_toandasset_idwill be set toNULL.This happens because in
snipe-it/app/Http/Controllers/Licenses/LicensesController.php:210the query incorrectly checks foridinstead oflicense_id.Additionally, this does not show up in the activity log.
Reproduction steps
...
Expected behaviour
The license B will be deleted and the seats of license A are not modified
Screenshots
No response
Snipe-IT Version
v6.1.2
Operating System
Ubuntu
Web Server
Apache
PHP Version
8.1
Operating System
Mac
Browser
Chrome
Version
114
Device
No response
Operating System
No response
Browser
No response
Version
No response
Error messages
Additional context
No response
The text was updated successfully, but these errors were encountered: