Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.11]Side navigation not aligned properly #15385

Closed
2 tasks done
swift2512 opened this issue Aug 23, 2024 · 3 comments
Closed
2 tasks done

[7.0.11]Side navigation not aligned properly #15385

swift2512 opened this issue Aug 23, 2024 · 3 comments

Comments

@swift2512
Copy link

swift2512 commented Aug 23, 2024

Debug mode

Describe the bug

Cosmetics.
'Predefined Kits', 'Settings', "Import', 'Requestable Items' use different style from other

  • items, menu icons and text not aligned properly.

    Reproduction steps

    Open Snipe-IT

    Expected behavior

    'Predefined Kits'
    Is: <i class="fa fa-object-group fa-fw" aria-hidden="true"></i>
    Should be: <i class="fas fa-object-group fa-fw" aria-hidden="true"></i>

    'Import'
    Is: <i class="fas fa-cloud-upload-alt fa-fw fa-fw" aria-hidden="true"></i>
    Should be: <i class="fas fa-cloud-upload-alt fa-fw" aria-hidden="true"></i>

    'Settings'
    Is: <i class="fa fa-cog" aria-hidden="true"></i>
    Should be: <i class="fas fa-cog fa-fw" aria-hidden="true"></i>

    'Requestable Items'
    Is: <i class="fa fa-laptop fa-fw" aria-hidden="true"></i>
    Should be: <i class="fas fa-laptop fa-fw" aria-hidden="true"></i>

    Screenshots

    image

    Snipe-IT Version

    Version v7.0.11 - build 15044 (master)

    Operating System

    ubuntu

    Web Server

    apache

    PHP Version

    8.3

    Operating System

    Windows 11

    Browser

    Edge, Firefox

    Version

    Latest

    Device

    No response

    Operating System

    No response

    Browser

    No response

    Version

    No response

    Error messages

    No response

    Additional context

    No response

  • @snipe
    Copy link
    Owner

    snipe commented Aug 23, 2024

    This was already fixed in f6319e1

    @snipe snipe closed this as completed Aug 23, 2024
    @swift2512
    Copy link
    Author

    I pulled today via girmt (fresh install) and there were these issues with text alignment. In my other instal with older master was an issue with overlapping < on settings cog, but this one is definitely fixrd in fresh install.

    snipe added a commit that referenced this issue Aug 23, 2024
    @swift2512
    Copy link
    Author

    swift2512 commented Aug 26, 2024

    @snipe You missed Settings cog. It's still fa fa-cog instead of fas fa-cog
    59 return 'fa fa-cog';
    image

    FlorentDotMe pushed a commit to TelecomsSansFrontieres/snipe-it that referenced this issue Sep 9, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants