BUG: EULA PDFs are not downloadable with S3 support

[federicosilvestri]

The function getStoredEula does not use S3 to generate a valid URL for the EULA PDFs.

snipe-it/app/Http/Controllers/ActionlogController.php

Line 40 in 49918d3

public function getStoredEula($filename) : Response | BinaryFileResponse | RedirectResponse

I suggest to implement the function like this:

public function getStoredEula($filename) : Response | BinaryFileResponse | RedirectResponse
    {
        $this->authorize('view', \App\Models\Asset::class);
        $disk = config('filesystems.default');
        
        switch (config("filesystems.disks.$disk.driver")) {
            case 's3':
                $file = 'private_uploads/eula-pdfs/'.$filename;
                return redirect()->away(Storage::disk($disk)->temporaryUrl($file, now()->addMinutes(5)));
            default:
                $file = config('app.private_uploads').'/eula-pdfs/'.$filename;
                if (Storage::exists('private_uploads/eula-pdfs/'.$filename)) {
                    return response()->download($file);
                }
                return redirect()->back()->with('error',  trans('general.file_does_not_exist'));
        }

    }

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

[snipe]

Can you take a look at this PR and see if it works for you? #16090

[federicosilvestri]

I have tested it in my environment and it works. Thank you.

[snipe]

Great, thanks for confirming. I still need to do a few more tests with local file storage, but once that's complete, it should be in the next release.

[federicosilvestri]

Perfect! Thank you! Il giorno sab 18 gen 2025 alle ore 14:33 snipe ***@***.***> ha scritto:

…

Great, thanks for confirming. I still need to do a few more tests with local file storage, but once that's complete, it should be in the next release. — Reply to this email directly, view it on GitHub <#16000 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHI3BBW37SAMEBA4HBQIKD2LJJZJAVCNFSM6AAAAABUE3JMRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZG4ZDAMBQHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- *Federico Silvestri* *Phone: +39 344 676 1408* *Primary Mail: ***@***.*** ***@***.***>* *Work mail: ***@***.*** ***@***.***>* *Skype: federico_silvestri*