Fixed extraneous wildcard query in asset search #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipe
reviewed
Jan 14, 2022
snipe
changed the title
I could've sworn I saw a full |
|
If you can pull it back, I'll merge it and check a little deeper locally - thanks! |
|
done |
|
Thankeeee!
|
snipe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [ch18482]
In the Requestable view (show everything that's requestable), we make an API query to populate the list of requestable assets. That API call performed a text search, whether or not the
?search=term was populated or not. This fixes that.Additionally, the web controller for the requestable page made an extraneous query to requestables, when all we need is the total count. This fixes that too.
None of these changes are super-urgent and none of them change any functionality or results, so we can absolutely take them after v6 lands.