Allow Sorting Based On EOL Date

[corydlamb]

Allowing sorting via EOL.

Description

Saw a post ( #12372 ) requesting this, gave this change a test on our server and it seems to work fairly well. If an asset has a buy date and EOL on the model it can sort by the dates.

Fixes #12372

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on my server, another really small change in the asset presenter file.

• Test A
• Test B

Test Configuration:

• PHP version: 8.1.11
• MySQL version 15.1
• Webserver version Apache 2.4.38
• OS version Turnkey Linux (updated to latest version of SNIPE (6.0.14)

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

• The field 'eol' is now sortable and visible.

[snipe]

EOL on the asset isn't sortable because it's not a native database field, it's calculated.

snipe-it/app/Http/Transformers/AssetsTransformer.php

Line 41 in 2564da6

'eol' => ($asset->purchase_date != '') ? Helper::getFormattedDateObject($asset->present()->eol_date(), 'date') : null,

snipe-it/app/Presenters/AssetPresenter.php

Lines 415 to 423 in 2564da6

	public function eol_date()
	{
	if (($this->purchase_date) && ($this->model->model) && ($this->model->model->eol)) {
	$date = date_create($this->purchase_date);
	date_add($date, date_interval_create_from_date_string($this->model->model->eol.' months'));
	return date_format($date, 'Y-m-d');
	}
	}

[corydlamb]

EOL on the asset isn't sortable because it's not a native database field, it's calculated.

snipe-it/app/Http/Transformers/AssetsTransformer.php

Line 41 in 2564da6

'eol' => ($asset->purchase_date != '') ? Helper::getFormattedDateObject($asset->present()->eol_date(), 'date') : null,

snipe-it/app/Presenters/AssetPresenter.php

Lines 415 to 423 in 2564da6

	public function eol_date()
	{
	if (($this->purchase_date) && ($this->model->model) && ($this->model->model->eol)) {
	$date = date_create($this->purchase_date);
	date_add($date, date_interval_create_from_date_string($this->model->model->eol.' months'));
	return date_format($date, 'Y-m-d');
	}
	}

Oh I see, my apologies!

[snipe]

I think we'd need to do something more like this to make it work: #12393

[snipe]

I'd be happy to go into more detail on that PR if you have questions - it does get a bit in the weeds. Definitely appreciate you trying to solve it via this PR though. As you can see, it's a little trickier than it first seems offhand, as so many things are.

[corydlamb]

I'd be happy to go into more detail on that PR if you have questions - it does get a bit in the weeds. Definitely appreciate you trying to solve it via this PR though. As you can see, it's a little trickier than it first seems offhand, as so many things are.

Thank you so much! I really appreciate how welcoming and freindly to novices like myself y'all are! I guess I'm just curious as to why calculated values shouldn't be sorted. There's a lot of reading up I should probably do on php tbh 😅

[snipe]

It's honestly largely just the complexity of the query in the database (AND people have asked to be able to edit that date directly in the past, so we can kill two birds with one stone here.) Even though we technically only officially support MySQL and MariaDB, I do know that some folks are using other databases (pgSQL, SQLite, etc) so we generally try to keep those queries as simple as possible for maximum compatibility. That said, my PR could get rejected by my team come Monday, so... we'll see :D

So it's a bit more of a product decision than it is a technical one, and there's no way you could have known every little thing that folks have asked for here.