Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footer sizing issue #12869

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Fixed footer sizing issue #12869

merged 3 commits into from
Sep 15, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Rethought the fix for the footer. I moved everything to one div.
Just one line of custom footer:
image

Extra Long custom footer with line breaks:
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@shortcut-integration
Copy link

@what-the-diff
Copy link

what-the-diff bot commented Apr 18, 2023

PR Summary

  • Footer layout updated
    The footer now uses a more modern layout technique called flexbox, improving its appearance and responsiveness.
  • Version number adjustments
    The version number has been relocated to the left side with a more subtle font style, making it less distracting.
  • Improved spacing in the footer
    Additional spacing has been added between the default footer text and any custom footer text, enhancing readability and visual appeal.

@Godmartinz Godmartinz changed the title Bug/sc 23134 Fixed footer sizing issue Apr 18, 2023
@snipe
Copy link
Owner

snipe commented Apr 24, 2023

This changes the current way the footer displays though. Maybe that's a good thing, maybe it's not.

Current:
Screenshot 2023-04-24 at 12 18 26 PM

The positions have changed here, where normally the "Snipe-IT is open source software" is on the left, version on the right, with the custom text ahead of it.

@Godmartinz
Copy link
Collaborator Author

Godmartinz commented Apr 25, 2023

Swapped it back 🙂
image
Footer text will appear on the line below as well.

@Godmartinz
Copy link
Collaborator Author

@snipe is there anything that needs to be rethought with this?

@Godmartinz
Copy link
Collaborator Author

Is this solution acceptable for now?

@snipe snipe merged commit 131ccaa into snipe:develop Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants