Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added users total cost of assets to user profile #12901

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

This adds a users total cost of assets they current use to the user profile. It also breaks down into Assets, Licenses, and Accessories.
image

Fixes #sc-19399

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Apr 24, 2023

PR Summary

  • Added a method to calculate user's total asset cost
    A new method has been added to the User model that calculates the total cost of assets, licenses, and accessories assigned to a user.

  • Updated language file for table view
    The language file has been updated with a new column name for the table view in the users section (total_assets_cost).

  • Display total cost and optional cost breakdown on user details page
    The user details page now includes a section that displays the calculated total cost value from the new method. Additionally, users can view a cost breakdown per asset type by clicking on the "optional info" link/icon next to the total cost.

@Godmartinz
Copy link
Collaborator Author

does this need any changes @snipe?

@snipe snipe merged commit b17af38 into snipe:develop Sep 5, 2023
@newburns
Copy link

Is there any way to have this value as a sortable column in the people view?

@snipe
Copy link
Owner

snipe commented Sep 25, 2023

Not currently, since it's calculated not a "real" column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants