Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tag for docker builds #12992

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Adds tag for docker builds #12992

merged 2 commits into from
Sep 20, 2023

Conversation

spencerrlongg
Copy link
Collaborator

@spencerrlongg spencerrlongg commented May 10, 2023

Description

Adds new tags for v{{major}}-latest and v{{major}}-latest-alpine

We may want to do {{version}} instead to get minor & patch numbers maybe?

Fixes #12853

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Untested at the moment, not sure if it needs to be, I don't have docker set up on this machine but can do that if I need to.

@what-the-diff
Copy link

what-the-diff bot commented May 10, 2023

PR Summary

  • Add SemVer tag for docker-alpine.yml
    Introduce a versioning system to manage the docker-alpine build.
  • Add SemVer tag for docker.yml
    Implement a versioning system to better manage the main docker build.

@snipe
Copy link
Owner

snipe commented May 10, 2023

@DanielWeigl care to weigh in here?

@snipe
Copy link
Owner

snipe commented May 24, 2023

Ping @DanielWeigl - can you put eyes on this when you get a moment?

@DanielWeigl
Copy link

DanielWeigl commented Jul 18, 2023

Hi, sorry for the late response, yes the changes look correct, but I don't have any experience with the GitHub build chain. So, im not sure if it will work as intented.

@snipe
Copy link
Owner

snipe commented Sep 15, 2023

@spencerrlongg can you let me know if this is ready to be taken out of WIP?

@spencerrlongg
Copy link
Collaborator Author

@uberbrady would you mind taking a look at this and seeing if it makes sense to you?

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty dang reasonable to me @spencerrlongg - as I understand it, it means that we'll now have 'v6-latest-alpine' and 'v6-latest' for those two particular builds - and when v7 comes out, we'll also have 'v7-latest-alpine' and 'v7-latest' - if that's what you're going for here, then that sounds good to me!

@spencerrlongg
Copy link
Collaborator Author

Alright, that's what they were asking for in the initial linked issue, so I'll mark ready for review, easy enough to revert if we have unintended consequences.

@spencerrlongg spencerrlongg marked this pull request as ready for review September 20, 2023 18:15
@snipe snipe merged commit 7c908fe into snipe:develop Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants