-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tag for docker builds #12992
Adds tag for docker builds #12992
Conversation
PR Summary
|
@DanielWeigl care to weigh in here? |
Ping @DanielWeigl - can you put eyes on this when you get a moment? |
Hi, sorry for the late response, yes the changes look correct, but I don't have any experience with the GitHub build chain. So, im not sure if it will work as intented. |
@spencerrlongg can you let me know if this is ready to be taken out of WIP? |
@uberbrady would you mind taking a look at this and seeing if it makes sense to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty dang reasonable to me @spencerrlongg - as I understand it, it means that we'll now have 'v6-latest-alpine' and 'v6-latest' for those two particular builds - and when v7 comes out, we'll also have 'v7-latest-alpine' and 'v7-latest' - if that's what you're going for here, then that sounds good to me!
Alright, that's what they were asking for in the initial linked issue, so I'll mark ready for review, easy enough to revert if we have unintended consequences. |
Description
Adds new tags for
v{{major}}-latest
andv{{major}}-latest-alpine
We may want to do {{version}} instead to get minor & patch numbers maybe?
Fixes #12853
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Untested at the moment, not sure if it needs to be, I don't have docker set up on this machine but can do that if I need to.