Fixed #13167 Default location not being set/updated upon check-in

[inietov]

Description

If a location is provided at asset checkin, we use to only set the location_id, but with this PR now we also set the rtd_location_id which is the Default Location, looks like a small change but I kinda struggle to fully understand the logic behind the referenced issue, so I hope it makes sense? I think it does but, not the first time I'm wrong!

I also got rid of an escaping e() method, because the system "control" the locations dropdown so I don't think it's necessary here.

Fixes #13167

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version: 8.0.31
• Webserver version: PHP dev server
• OS version: Debian 11

[what-the-diff]

PR Summary

• Modification in AssetCheckinController.php File
  • The log message has been enhanced to now show the new location ID, providing a better understanding of the asset location changes.
  • Adjustments were made to the location_id property of the Asset object. Initially, it was set to an empty string but later updated to reflect the rtd_location_id. This will ensure that the Asset object reflects the correct location information.
  • Comprehensive updates were done to thelocation_id attribute of rtd_location_id and Asset object from the request. This change allows the object properties to be dynamically updated based on the incoming requests.
  • Another modification is the rtd_location_id property of the Asset object which has been updated to the value of the location_id attribute from the request. This ensures that the returned to depot location ID always represents the latest data from the request.

[inietov]

Put it as draft because I found an issue, as I put this on the partials view, the option also is shown in the update asset view. As soon as it's resolved I change the draft to pull request again.

[inietov]

Ok, that was fast... I though it would take me more time to remove the inputs from other views.Sorry... Back to ready for review!