Check for max PHP version in upgrader #13257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just tweaks the upgrade script to check for a version of PHP that's too high. While this is documented in the Requirements section of the docs, this should hopefully provide a safeguard or at least more visual feedback to the upgrading.
If it passes (I had an early exit after the version check just to be able to test - it would normally just continue through the upgrader):
If it fails (I had to use a fake max version number here to trigger the fail):