Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes dev dependency on PHP 7.4 #13282

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fixes dev dependency on PHP 7.4 #13282

merged 1 commit into from
Jul 11, 2023

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Jul 11, 2023 •
edited
Loading

Description

Either this PR or #13283 should be pulled in...not both.

This PR allows composer install to successfully run on PHP 7.4 when installing dev dependencies by lowering the required version of vimeo/psalm.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@marcusmoore marcusmoore requested a review from snipe as a code owner July 11, 2023 00:41
@probot-autolabeler probot-autolabeler bot added backend dependencies Pull requests that update a dependency file labels Jul 11, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 11, 2023

PR Summary

  • Updated Vimeo/Psalm Dependency
    The version of "Vimeo/Psalm" (a tool used for ensuring the quality of the code) has been updated to a more recent one. This change can lead to improved code analysis that can help catch potential errors or inefficiencies.

@marcusmoore marcusmoore mentioned this pull request Jul 11, 2023
Closed
1 task
@snipe snipe merged commit d76f420 into snipe:develop Jul 11, 2023
@marcusmoore marcusmoore deleted the fixes/allow-installing-on-74-v2 branch July 11, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
backend dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusmoore @snipe