Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Employee Number no longer importing [sc-23497] #13318

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Jul 17, 2023

Description

The field mapping in the User Importer was using an incorrect field name for Employee Number ´employee_number´ instead of ´employee_num´. I was thinking if we made this change to make the field name clearer or more easily readable? But I change it to ´employee_num´ anyways because I don't think it was hard to understand that way either.

Fixes [sc-23497]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.31
  • Webserver version: PHP Dev server
  • OS version: Debian 11

@inietov inietov requested review from uberbrady and snipe July 17, 2023 18:29
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23497: Employee ID no longer importing.

@what-the-diff
Copy link

what-the-diff bot commented Jul 17, 2023

PR Summary

  • Simplified employee identification
    The key that we use to identify each employee in our system has been changed from employee_number to a simpler term, employee_num. This change will keep the system consistent and make it easier for our admins to manage employee data.

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thank you!

@snipe snipe merged commit cbdce99 into snipe:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants