Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed custom fieldset order #13361

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fixed custom fieldset order #13361

merged 2 commits into from
Jul 26, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Custom Fieldsets order would start at zero, they now start at 1.

Before:
image

After:
image

Fixes #sc-19126

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #19126: Custom fields order display is wonky.

@what-the-diff
Copy link

what-the-diff bot commented Jul 25, 2023

PR Summary

  • Enhanced Field Order Display
    The counting of the field order in a certain view page was updated so instead of starting from the initial value, it will begin with the initial value plus one. This makes it more intuitive for users who are more familiar with counting starting from one instead of zero.

@snipe snipe merged commit af86c61 into snipe:develop Jul 26, 2023
@snipe
Copy link
Owner

snipe commented Jul 26, 2023

This seems like a bit of a cheat, but I'll take it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants