Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed webhook_endpoint data type from varchar to a text #13392

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Changes the webhook_endpoint variable from varchar to a text allowing more characters.

Fixes #FD-37153

Type of change

Please delete options that are not relevant.

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner August 1, 2023 17:47
@what-the-diff
Copy link

what-the-diff bot commented Aug 1, 2023

PR Summary

  • Adjustment of Data Type for Webhook Endpoint
    This update includes a new system migration file provides an enhancement which modifies the webhook_endpoint in the settings table. The change is technical in nature, shifting its type from varchar(short text) to text (long text), enabling more data to be stored for this specific field.

@Godmartinz Godmartinz changed the title Fixed webhook_endpoint from varchar to a text Fixed webhook_endpoint data type from varchar to a text Aug 1, 2023
@snipe
Copy link
Owner

snipe commented Aug 1, 2023

Do we need to make sure to state ->default(null)->nullable() here so we don't revert that state?

@Godmartinz
Copy link
Collaborator Author

Godmartinz commented Aug 1, 2023

I dont think so, is_nullable is still set to true/yes in the database.
image

The initial migration set that up correctly?

@snipe
Copy link
Owner

snipe commented Aug 1, 2023

Yeah, just wasn't sure whether ->change() changed all of the characteristics or just the ones you specify. If your migration looks good, I'm in.

@snipe snipe merged commit 924f528 into snipe:develop Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants