Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13382 The time zone is configured correctly and the date does not change anyway #13399

Closed
wants to merge 1 commit into from

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Aug 2, 2023

Description

The Localization Settings view uses current year and month to show different date formats, but the day is fixed to '-25'. Some user was claiming that this should change with the timezone config, so I changed it to use current day. This screen:
image

I'm not sure if it's a legitimate problem, and I ask, but is reasonably small and easy change to be made. If this change is not desired we can just close this PR and inform user. No big deal :)

Fixes #13382

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.31
  • Webserver version: PHP dev server
  • OS version: Debian 12

@inietov inietov requested review from uberbrady and snipe August 2, 2023 22:26
@what-the-diff
Copy link

what-the-diff bot commented Aug 2, 2023

PR Summary

  • Improved Date Formatting in macros.php
    The code has undergone modifications to enhance the display format of dates. Now, instead of using a designated day every month, the date formatting will accurately present the current day. This change ensures that date information is always relevant and up to date.

@snipe
Copy link
Owner

snipe commented Aug 3, 2023

In my original localization PR that added this UI setting, I specifically decided to use 25 so that more confusing date formats would be clearer. For example, 03-02-2023 could mean March 2, 2023 or February 3, 2023, depending on how you’re used to seeing dates. Since 25 isn’t a valid number for a month, it makes it clearer versus using the current day of the month, IMHO, but am open to being convinced otherwise.

@snipe
Copy link
Owner

snipe commented Aug 9, 2023

Per internal discussions, I think we're going to handle this a different way. TY for this tho @inietov!

@snipe snipe closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants