-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added messaging to category edit page to improve clarity around when users will be emailed #13407
Conversation
This pull request has been linked to Shortcut Story #23465: Improve messaging around if emails will be sent in category edit view. |
PR Summary
|
(The ChipperCI error should be fixed in #13414) |
Description
This PR adds messages to the category edit page to provide clarity around when users will receive emails when checking out an item from that category.
Taking this page as an example that exists before this PR:
Users will still receive an email after check out even though
Send email to user on checkin/checkout
is unchecked because the category has a EULA set (This category's EULA.
). This is also the case if no EULA is set but theUse the primary default EULA instead
is checked:This PR adds a message explaining when users will be receiving an email and automatically checks and disables the
Send email to user on checkin/checkout
input:In gif form:
Additional Notes
Previously, the
checkin_email
property in the database for categories was not always accurate since it was possible that an email would be sent due to the conditions mentioned above. Now, if the checkbox is programmatically selected the value is updated in the database as well.Type of change