Added CompanyableTrait
to Department
model
#13415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
couple(see edit) simple tests around theApi/DepartmentsController
'sindex
method to ensure it returns the number of rows expected (specific values aren't tested) and that the results adhere to full company scoping when it is enabled.Since we have a passing test for adhering to company scoping we can add the
CompanyableTrait
to theDepartment
model and remove theCompany::scopeCompanyables()
wrapper in the controller.This is another small step in the direction of simplifying how models are scoped to companies.
Edit: snuck in a couple more simple tests for authentication and authorization.
Type of change