Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add the option for asset_eol_date as an import field #13421

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

uberbrady
Copy link
Collaborator

@uberbrady uberbrady commented Aug 8, 2023

[fd-36545] We had this before, but due to a refactor it somehow got merged out :/

I tested this by uploading a CSV with a specific EOL date set in a column, and mapping that (well, it auto-mapped), and then importing, and then making sure that the assets showed up with that EOL date. That worked.

@what-the-diff
Copy link

what-the-diff bot commented Aug 8, 2023

PR Summary

  • Introduction of 'asset_eol_date' to mount() function
    The addition of a new field named 'asset_eol_date' to the mount() function in Importer.php. This will improve how the system manages and tracks the end-of-life dates for various assets, enhancing the overall asset management within the system.

@snipe snipe merged commit 9e6f23c into snipe:develop Aug 8, 2023
@snipe
Copy link
Owner

snipe commented Aug 8, 2023

I don't really understand how that got refactored out. That change was just added in May.

@snipe
Copy link
Owner

snipe commented Aug 8, 2023

Thanks for re-adding it tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants