Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tooltip not loading on encrypted field lock icon on asset detail view #13424

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 8, 2023

This fixes an issue reported in SC-23552 where the "encrypted field" tooltip was showing as blank - and also fixes one we didn't notice, which is that the tooltip doesn't load at all if you switch models on edit or create, since the DOM is already loaded when we ajax in those form fields.

Before

Clipboard 2023-25-07 at 5 02 37 PM

After

Screenshot 2023-08-08 at 6 56 11 PM

On switching models in create/edit

Screenshot 2023-08-08 at 6 56 25 PM

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23552: Tooltip doesn't render text correctly.

@what-the-diff
Copy link

what-the-diff bot commented Aug 8, 2023

PR Summary

  • Integration of Bootstrap 3 Tooltip
    Bootstrap 3's tooltip feature has been added in resources/views/layouts/default.blade.php, which will allow additional informational text to be shown when users hover over certain elements in the web application.

  • Tooltip Re-initialization After DOM Load
    A new script has been implemented in resources/views/models/custom_fields_form.blade.php. This allows the tooltip feature to be re-initialized and function as expected after the Document Object Model (DOM) has fully loaded on the page. This ensures the tooltip feature continues working even if the page content changes dynamically.

@snipe snipe deleted the bug/sc-23552 branch August 8, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant