Improved test stability and messaging #13434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This tiny PR simply improves some of our custom test response helpers by escaping the model property being checked and adding a help messages that are displayed during failures.
It was rare but I noticed sporadic failures running tests locally when faker generated a name within a factory that had punctuation in it. For example, looking for the generated name
O'Shea
would fail because API responses have the values escaped so we should actually be looking forO'Shea
.