Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email to companies #13442

Merged

Conversation

Robert-Azelis
Copy link
Contributor

Description

Add emial field to companies

Type of change

  • Improvement

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Aug 13, 2023

PR Summary

  • Addition of Email Field to Company Controller Files
    The 'email' field has been added to both the main and API Company Controller files. These updates allow the system to manage companies' email information in both standard and API contexts.

  • Email Field Integration to Company Data Transformation Procedures
    The 'email' field has been included in the Companies Data Transformer to ensure company email information is correctly transformed for appropriate use across the system.

  • Updated Validation Rules & Search Ability in Company Model
    The email field has been included in the Company Model's validation rules to guarantee data integrity for email inputs. Moreover, the email field has been integrated into the searchable attributes to provide smooth email-based search functionality.

  • Email Field Visual Integration in Data Presentation
    The Company data table layout now includes the 'email' field. This modification enhances data visibility for companies’ email information.

  • Database Schema Modification
    A migration file has been added to include 'email' field in the 'companies' database table. This expansion in database schema accommodates the storage of company email data.

  • UI Enhancement For Email Information Editability
    The company edit form now includes an input for 'email' information. This improvement makes it easier for any user to update company email data.

@snipe
Copy link
Owner

snipe commented Aug 14, 2023

Is this something people need though? Every new field/feature is a new touch point that we need to test and maintain.

@Robert-Azelis
Copy link
Contributor Author

Robert-Azelis commented Aug 14, 2023

Is this something people need though? Every new field/feature is a new touch point that we need to test and maintain.

Yes, this field is very useful in case use multi companies. Easy to create API report and send via distribution group mail (per company). In future posible to use/implement distribute build-in reports per company.

@snipe snipe merged commit c56f664 into snipe:develop Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants