Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13446 - added translations to status label type column #13448

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Aug 14, 2023

Description

Updates the statusLabelTypeFormatter with a translation variable for the status_type column in the table.

image image

Fixes #13446

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Aug 14, 2023

PR Summary

  • Enhanced Language Support
    The method, getStatuslabelType, has been updated to support multiple languages. Instead of returning basic text, it now returns translated text based on user settings, making our software more inclusive and user-friendly across varied demographics.

@snipe snipe changed the title added translations to status label type column Fixed #13446 - added translations to status label type column Aug 14, 2023
@snipe
Copy link
Owner

snipe commented Aug 14, 2023

This is going to hitch us up in the API I think.

if ($asset->assetstatus->getStatuslabelType() == 'pending') {
$asset->use_text .= '('.$asset->assetstatus->getStatuslabelType().')';
}

@Godmartinz
Copy link
Collaborator Author

@snipe I rethought it and fixed it through the table formatter instead of the model.

@snipe
Copy link
Owner

snipe commented Aug 14, 2023

Nice!

@snipe snipe merged commit aa333bc into snipe:develop Aug 14, 2023
@floschoepfer
Copy link
Contributor

Hey @Godmartinz thanks for this!
I just noticed, that the status "deployable" now has a red circle as icon instead of a red cross. I like that, since the status "archived" already uses a red cross.

But could you please add the icon also to the "About Status Labels" descriptions, so it is consistent?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants