Fixed #13317 Accessories declined by user remain assigned

[inietov]

Description

When an accessory is checked out and acceptance is required, if the user rejects the asset it remains assigned to them. This is contrary to the behavior on assets which are unassigned if declined, so I added the declinedCheckout method to the Accessory model.

Then, as the linked issue remarks, the signature when the asset is rejected is not showed in history. I also add this to the declined item functionality. Maybe is a little out of scope, but I think it's a small change and can be made here.

Fixes #13317

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version: 8.0.31
• Webserver version: PHP dev server
• OS version: Debian 11

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Enhancements to 'AcceptanceController.php'

  • The script now ensures the directories eula-pdfs and signatures exist before they are needed. This resolves any potential issues due to their absence.
  • This update also introduces the ability to save a signature as an image file during item acceptance, providing a stronger authentication measure.
  • Moreover, if no signature image data is given during item acceptance, the user will now be redirected back with an error message, enhancing the system's validation process.
  • The declined notification has been improved to include a signature field, providing more detailed information when an item is not accepted.
  • Our system can now generate and save a PDF if the pdf_view_route is specified, adding to its existing functionality.
  • A change has been made to the execution of the $acceptance->decline() method whereby the $sig_filename parameter is included. This provides a more detailed log in declined transactions.

• Addition to 'Accessory.php' file

  • A new method, declinedCheckout(), has been introduced to handle declined checkouts for accessories. This creates a more streamlined process for managing the denial of checkout requests for different accessory items.

[marcusmoore]

I tested this locally and it works 👍🏾

One minor request but overall good stuff 😄

[inietov]

Kindly pinging @snipe, this looks ok to you? or need some more work?