Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #13450 - remove escaping on saveing new custom fields #13454

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fixed #13450 - remove escaping on saveing new custom fields #13454

merged 1 commit into from
Aug 14, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 14, 2023

This fixes #13450 - we were escaping the fieldset name on storing a new fieldname.

@snipe snipe requested a review from uberbrady as a code owner August 14, 2023 21:22
@snipe snipe merged commit dcec4ba into develop Aug 14, 2023
@snipe snipe deleted the fixes/13450_removed_escaping_custom_fieldsets branch August 14, 2023 21:22
@what-the-diff
Copy link

what-the-diff bot commented Aug 14, 2023

PR Summary

  • Unescaped name attribute in CustomFieldsetsController.php
    The name attribute of our data item, previously escaped or partially replaced for security reasons, is now no longer treated this way. This should make our code cleaner and easier to handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uberbrady uberbrady Awaiting requested review from uberbrady uberbrady is a code owner

Assignees
No one assigned
Labels
backend custom fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snipe