Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13382 - confusion around localization date #13455

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 14, 2023

Fixes #13382 - This is a small change that will hopefully clear up confusing around the date format select list. I had previously used this month, then the day of 25, and the current year (so that date formats like Feb 3, 2023 - which could be month-day-year OR day-month-year would be clearer, since there is no 25th month), but it seems it was causing confusion. This uses today's date, and hopefully the format is guessable via the other options in the menu.

This could still be confusing if the user is changing this on a day where the month and the day are the same (Feb 2, 2023) which was also what I was trying to avoid, but hopefully this will help. (I had considered including the $format in the dropdown, but not everyone will know what n/d/y means. ¯_(ツ)_/¯

@what-the-diff
Copy link

what-the-diff bot commented Aug 14, 2023

PR Summary

  • Adjustment to Date Display Formats
    The way that dates are displayed has been changed. We now employ the Carbon library for formatting and reading dates, which will provide more accuracy and flexibility.

  • Style Enhancement for Select Elements
    The style attributes for selection elements have been adjusted to have a 100% minimum width, improving the consistency of our user interface.

  • Modification of Layout in localization.blade.php
    The layout of certain sections in the localization.blade.php file has been updated. These modifications adjusted the widths of a couple of items for a more balanced visual arrangement.

  • Update to an Error Message Format
    An error message tied to the 'time display format' has been modified. The message is now contained within an additional layer, which should help make its usage more flexible.

@snipe snipe merged commit d3fbbec into develop Aug 14, 2023
@snipe snipe deleted the fixes/confusion_around_localization_date branch August 14, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant