Fixed passing invalid argument to strpos()
#13456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed a couple tests failing when run on PHP 7.4 due to an empty string being passed as the second parameter to strpos() which isn't valid pre-8.0.
This small PR moves the existing
$prefix == ''
up so callingstrpos
is skipped if the prefix is an empty string.@uberbrady can you double-check this makes sense please?
Type of change