Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #13359 Advanced search by Default Location does not work #13483

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fixed #13359 Advanced search by Default Location does not work #13483

merged 1 commit into from
Aug 17, 2023

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Aug 16, 2023

Description

Advanced search when looking for default location (rtd_location) wasn't working. This PR adds the query to Asset model scopeByFilter() method.

Fixes #13359

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.31
  • Webserver version: PHP dev server
  • OS version: Debian 11

@what-the-diff
Copy link

what-the-diff bot commented Aug 16, 2023

PR Summary

  • Enhanced Filter Functionality in "Asset" Model
    The update now allows users to search for assets based on their "returned-to-department" locations. This enhanced filter offers a more comprehensive search, allowing users to locate assets with a specific departmental return location more easily.

marcusmoore
marcusmoore approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏾

@snipe snipe merged commit 03a01c0 into snipe:develop Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusmoore marcusmoore marcusmoore approved these changes

@uberbrady uberbrady Awaiting requested review from uberbrady

@snipe snipe Awaiting requested review from snipe snipe is a code owner

@spencerrlongg spencerrlongg Awaiting requested review from spencerrlongg

@Godmartinz Godmartinz Awaiting requested review from Godmartinz

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inietov @marcusmoore @snipe